Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Angular & Next Tags #1050

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Update Angular & Next Tags #1050

merged 2 commits into from
Jan 12, 2025

Conversation

wildcraft958
Copy link
Contributor

angular and next tags updates

Closes: #1045

  • Title: Updated tags
  • Name: Animesh
  • Idenitfy yourself: KWOC Contributor

Describe the add-ons or changes you've made 📃

As instructed I have updated the tags of angular and next projects in data.json file with the correct tags as mentioned in their respective README files.

Screenshots 📷

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

@Avdhesh-Varshney

@wildcraft958
Update data.json
cdf075c 
angular and next tags updates
@vercel Vercel
Copy link

vercel bot commented Dec 22, 2024

@wildcraft958 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Avdhesh-Varshney
Avdhesh-Varshney requested changes Dec 23, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • URL shortner uses tailwind css and typescript. But you have mentioned it incorrectly.
  • Also, correct other projects properly not just moving the tags up and down.

Don't go with the README whatever they have mentioned.

@wildcraft958
correction made
804f202 
updated them as per package.json
@wildcraft958
Copy link
Contributor Author

@Avdhesh-Varshney Changes has been made

@wildcraft958
Copy link
Contributor Author

@Avdhesh-Varshney I have already made changes a while ago please review

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 4:48pm

@Avdhesh-Varshney Avdhesh-Varshney changed the title Update data.json Update Angular & Next Tags Jan 3, 2025
@Avdhesh-Varshney Avdhesh-Varshney merged commit 2749abc into Avdhesh-Varshney:main Jan 12, 2025
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement New feature or request Status: Approved KWOC documentation Improvements or additions to documentation and removed bug Something isn't working Status: Review Ongoing enhancement New feature or request labels Jan 12, 2025
@wildcraft958 wildcraft958 deleted the patch-1 branch January 12, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney approved these changes

@Lickhill Lickhill Awaiting requested review from Lickhill

@Sumit6307 Sumit6307 Awaiting requested review from Sumit6307

Assignees

@wildcraft958 wildcraft958

Labels
documentation Improvements or additions to documentation KWOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Update the vanilla-js tags of the projects in data.json file
2 participants
@wildcraft958 @Avdhesh-Varshney